[make:crud][experimental] Add generated tests to make:crud

[ckrack]

Add tests for the controller methods.
Add necessary dependencies.
Closes #229

Edit by @jrushlow:

• Feature is experimental - We generate a minimum WebTestCase for generated CRUD.
• Generating tests is on an opt-in basis if the user has test-pack already installed. Otherwise we're not advertising this feature yet.
• Entity / Form Field guessing is not fully implemented. "Setter" values other than string will not match the Entity's property types and must be manually changed.
• Tests (other than testIndex()) are all generated with markTestIncomplete()
• Better integration w/ Panther, Fixtures, Foundry, etc... to come in future PR's

[weaverryan]

Sorry for the delay @ckrack! That's my bad - but I'm pretty excited about the possibilities with this PR. Let's chat if you have questions / thoughts.

[weaverryan]

Instead of depending on testNew, we should create an entity directly via the EntityManager here and persist it. Depending on testNew is convenient at first, but it couples the test methods together, which has a practical downside: I now need to run two full tests before running this test (testIndex, then testNew, then this one).

Btw, I'm not so sure that we need to comment out all of the edit tests. Because... we know what entity is being generated. And so, we could write some code to instantiate that object and persist it. Heck... thinking crazy, we could use faker and introspect the Doctrine annotation information to even fill in the required fields if they have Faker installed (we could recommend it).

It's a bit more work, but in theory, we could make these tests fully (or nearly fully) functional.

[ckrack]

I have looked into using Faker for the test generation.

What is easily achievable is using Faker inside the tests to populate Entities based on their properties.
However, this will lead to tests never failing when properties were changed. Faker will always use an up-to-date generator, because the guesser bases on the current entity
Tests will only fail if the Form is not updated and requires a change, too.

This looks like:

// App\Test\Controller\ExampleControllerTest;
// inside a test* method that needs an entity in the db:
$entityPopulator = new EntityPopulator($this->entityManager->getClassMetadata(Test::class));
$entityPopulator->setColumnFormatters($entityPopulator->guessColumnFormatters($this->fakerGenerator));

/** @var App\Entity\Test */
$test = $entityPopulator->execute($this->entityManager, []);

$this->entityManager->persist($test);
$this->entityManager->flush();

One could argument that this is enough, because we are testing the controller - not the entity or form.
I'd prefer to generate tests that contain somewhat fixed values and will fail, when either the entity or form are changed.
So tests could either contain faker generator calls $faker->name() or the output of this. The former would require reverse-engineering Faker's name guesser, as the populators are returned as closures and do not allow retrieving their name.
This means we must keep a copy of this up to date, to allow getting the generator names as string: https://github.com/fzaninotto/Faker/blob/master/src/Faker/Guesser/Name.php
Not the best option.

This is also complicated, due to association mappings.
We can leave them out or auto-populate them in the tests.
If we leave them out, the generated tests will fail - our test of the maker command must reflect this.

WDYT?

[weaverryan]

@ckrack Do you still have an interest in finishing this? Or should we try to find another volunteer? :)

[TheGarious]

Up.

Need Help for finish this PR ?

[weaverryan]

What would happen if we didn't check for the class? And just always asked the question? If they ran the tests, obviously they wouldn't work, but would it be obvious that they just need to install some stuff? I'm trying to limit the number of conditionals and paths we have.

[jrushlow]

Welp nothing - good catch!

[jrushlow]

Thanks @ckrack for getting this going!

[weaverryan]

Thank you @ckrack and @jrushlow!