Skip to content

Add a warning when no routes are defined #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 12, 2017
Merged

Add a warning when no routes are defined #5

merged 2 commits into from
Nov 12, 2017

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Nov 11, 2017 •
edited
Loading

image

@fabpot fabpot force-pushed the warning-no-routes branch 4 times, most recently from 698051f to b132997 Compare November 11, 2017 23:21
ogizanagi
ogizanagi approved these changes Nov 12, 2017
View reviewed changes
src/Command/MakeControllerCommand.php Outdated
if (!count($this->router->getRouteCollection())) {
$io->text('<error> Warning! </> No routes configuration defined yet.');
$io->text(' You should probably uncomment the annotation routes in <comment>config/routes.yaml</>');
$this->io->writeln('');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

-            $this->io->writeln('');
+            $io->newLine();

?

weaverryan
weaverryan approved these changes Nov 12, 2017
View reviewed changes
Copy link
Member

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea!

@fabpot fabpot merged commit 2c2917f into master Nov 12, 2017
fabpot added a commit that referenced this pull request Nov 12, 2017
@fabpot
feature #5 Add a warning when no routes are defined (fabpot)
cb5a8de 
This PR was squashed before being merged into the master branch (closes #5).

Discussion
----------

Add a warning when no routes are defined

![image](https://user-images.githubusercontent.com/47313/32694414-ebd6fbe8-c6f3-11e7-8ec4-58088685a820.png)

Commits
-------

2c2917f simplified some code
31c6606 added a warning when no routes are defined
@xabbuh xabbuh deleted the warning-no-routes branch November 13, 2017 06:47
@sadikoff sadikoff mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fabpot @weaverryan @ogizanagi