Use object typehint when generating entities#872
Merged
jrushlow merged 1 commit intosymfony:mainfrom Apr 26, 2022
HypeMC:object-typehint
Merged
Use object typehint when generating entities#872jrushlow merged 1 commit intosymfony:mainfrom HypeMC:object-typehint
jrushlow merged 1 commit intosymfony:mainfrom
HypeMC:object-typehint
Conversation
jrushlow
requested changes
May 10, 2021
Collaborator
jrushlow
left a comment
jrushlow
left a comment
There was a problem hiding this comment.
I like the idea! Anytime we can set explicit types, the better. We do however need to move the PHP version conditional logic into the PhpCompatUtil::class
src/Util/ClassSourceManipulator.php
Outdated
| return '\\'.\DateInterval::class; | ||
|
|
||
| case 'object': | ||
| return \PHP_VERSION_ID < 70200 ? null : 'object'; |
Collaborator
There was a problem hiding this comment.
This check should be done in the PhpCompatUtil -> https://github.com/symfony/maker-bundle/blob/main/src/Util/PhpCompatUtil.php
Something along the lines of PhpCompatUtil::canUseObjectReturnType()
Member
Author
There was a problem hiding this comment.
@jrushlow Since the maker bundle now requires PHP 7.2.5+ I've removed all conditional logic.
HypeMC
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use object typehint when adding object entity fields.