Skip to content

Add mariadb example to DATABASE_URL #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Add mariadb example to DATABASE_URL #1186

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27a6a70
Add mariadb example to DATABASE_URL
alexander-schranz Mar 20, 2023
50d75d4
Apply change requests
alexander-schranz Mar 20, 2023
fad35c5
Use same casing as in the doctrine/dbal mariadb docs
alexander-schranz Mar 20, 2023
05f13e4
Update doctrine/doctrine-bundle/2.8/manifest.json
alexander-schranz Mar 20, 2023
475a42a
Use only major version for postgresql serverVersion
alexander-schranz Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doctrine/doctrine-bundle/2.8/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
"#2": "IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml",
"#3": "",
"#4": "DATABASE_URL=\"sqlite:///%kernel.project_dir%/var/data.db\"",
"#5": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=8&charset=utf8mb4\"",
"#5": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=mariadb-10.11&charset=utf8mb4\"",
Copy link
Member

@derrabus derrabus Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should specify the version as the server would report it, otherwise later versions of DBAL will fail to parse it.

Suggested change
"#5": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=mariadb-10.11&charset=utf8mb4\"",
"#5": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=10.11.2-mariadb&charset=utf8mb4\"",

Copy link
Member

@derrabus derrabus Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the DBAL docs are outdated in that regard.

Copy link
Contributor Author

@alexander-schranz alexander-schranz Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, didn't know that.

Copy link
Member

@derrabus derrabus Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctrine/dbal#5971

"#6": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=8&charset=utf8mb4\"",
Copy link
Member

@derrabus derrabus Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle is rolling out new features in MySQL 8.0.X releases nowadays, so it's a good practice to specify the full version.

Suggested change
"#6": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=8&charset=utf8mb4\"",
"#6": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=8.0.32&charset=utf8mb4\"",

Copy link
Contributor Author

@alexander-schranz alexander-schranz Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always fan of full version 👍 . Should we specifiy it also for postgresql?

Copy link
Member

@derrabus derrabus Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specifiy it also for postgresql?

We can do this for the sake of consistency, but since Postgres implements a much saner versioning policy, it's not really necessary.

"DATABASE_URL": "postgresql://app:[email protected]:5432/app?serverVersion=15&charset=utf8"
},
"dockerfile": [
Expand Down