Skip to content

Add mariadb example to DATABASE_URL #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2023
Merged

Add mariadb example to DATABASE_URL #1186

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
27a6a70
Add mariadb example to DATABASE_URL
alexander-schranz Mar 20, 2023
50d75d4
Apply change requests
alexander-schranz Mar 20, 2023
fad35c5
Use same casing as in the doctrine/dbal mariadb docs
alexander-schranz Mar 20, 2023
05f13e4
Update doctrine/doctrine-bundle/2.8/manifest.json
alexander-schranz Mar 20, 2023
475a42a
Use only major version for postgresql serverVersion
alexander-schranz Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions doctrine/doctrine-bundle/2.8/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@
"#2": "IMPORTANT: You MUST configure your server version, either here or in config/packages/doctrine.yaml",
"#3": "",
"#4": "DATABASE_URL=\"sqlite:///%kernel.project_dir%/var/data.db\"",
"#5": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=8&charset=utf8mb4\"",
"DATABASE_URL": "postgresql://app:[email protected]:5432/app?serverVersion=15&charset=utf8"
"#5": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=8.0.36&charset=utf8mb4\"",
"#6": "DATABASE_URL=\"mysql://app:[email protected]:3306/app?serverVersion=10.11.2-MariaDB&charset=utf8mb4\"",
"DATABASE_URL": "postgresql://app:[email protected]:5432/app?serverVersion=15.2&charset=utf8"
Copy link
Member

@fabpot fabpot Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using "full" version looks pretty annoying to me. It means you need to be sure you keep this in sync with your DB version. Is it really needed for all platforms?

Copy link
Contributor Author

@alexander-schranz alexander-schranz Mar 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Atleast for mysql there is a version_compare for 5.7.9:

And for mariadb a version_compare on 10.2.7:

On the doctrine dbal createDatabasePlatformForVersion method. So there make it sense to define it from my point of view.

We could remove it from postgresql currently? @derrabus what do you think, is that still future proof?

PS: Currently Symfony CLI Local Webserver overwrites the DATABASE_URL with a value without ?serverVersion which ends in unexpected errors for application require the ?serverVersion to be defined correctly: symfony-cli/symfony-cli#108

Copy link
Member

@derrabus derrabus Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For MySQL flavors we do need the full version. Oracle keeps shipping features and deprecating stuff in 8.0.x releases, unfortunately.

},
"dockerfile": [
"RUN apk add --no-cache --virtual .pgsql-deps postgresql-dev; \\",
Expand Down