Fix exit code handling for Symfony 6 compatibility message#1510
Open
outcomer wants to merge 1 commit intosymfony:mainfrom
Open
Fix exit code handling for Symfony 6 compatibility message#1510outcomer wants to merge 1 commit intosymfony:mainfrom
outcomer wants to merge 1 commit intosymfony:mainfrom
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title: Fix exit code handling in create-project job
Summary
This PR fixes the exit code handling in the "Create-project with skeleton ^6" step so that the informational message is correctly displayed when a package doesn't support Symfony 6.
Related issues:
Issues Fixed
Missing
$prefix: The condition[[ EXIT_CODE -eq 2 ]]was missing the$beforeEXIT_CODE, causing the check to always failScript exits before capturing exit code: GitHub Actions runs bash with -e flag, so when composer require fails, the script exits immediately before
EXIT_CODE=$?can capture the exit code. Fixed by usingEXIT_CODE=0followed bycomposer require ... || EXIT_CODE=$?Improved message formatting: Added a green-colored border box for better visibility in the logs
Before
After