[symfony/mailgun-mailer] Align env examples with README#1533
Open
ttskch wants to merge 1 commit intosymfony:mainfrom
Open
[symfony/mailgun-mailer] Align env examples with README#1533ttskch wants to merge 1 commit intosymfony:mainfrom
ttskch wants to merge 1 commit intosymfony:mainfrom
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. symfony/mailgun-mailer4.3 vs 4.4diff --git a/symfony/mailgun-mailer/4.3/manifest.json b/symfony/mailgun-mailer/4.4/manifest.json
index 576fd92f..80a6c62e 100644
--- a/symfony/mailgun-mailer/4.3/manifest.json
+++ b/symfony/mailgun-mailer/4.4/manifest.json
@@ -1,10 +1,7 @@
{
"env": {
- "#1": "MAILGUN_USERNAME=",
- "#2": "MAILGUN_PASSWORD=",
- "#3": "MAILER_DSN=smtp://$MAILGUN_USERNAME:$MAILGUN_PASSWORD@mailgun",
- "#4": "MAILGUN_KEY=",
- "#5": "MAILGUN_DOMAIN=",
- "#6": "MAILER_DSN=http://$MAILGUN_KEY:$MAILGUN_DOMAIN@mailgun"
+ "#1": "MAILER_DSN=mailgun+smtp://USERNAME:PASSWORD@default?region=us",
+ "#2": "MAILER_DSN=mailgun+https://KEY:DOMAIN@default?region=us",
+ "#3": "MAILER_DSN=mailgun+api://KEY:DOMAIN@default?region=us"
}
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing examples only show the bare
mailgun://scheme (which resolves toMailgunHttpTransport) andmailgun+smtp://. Themailgun+api://scheme is missing, andmailgun://is easily misinterpreted as "the default/API transport" while it actually uses the raw MIME endpoint that lacks first-class support for features likerecipient-variables.This aligns the recipe with the three explicit schemes documented in the current mailgun-mailer README:
mailgun+smtp://(SMTP)mailgun+https://(HTTP, raw MIME)mailgun+api://(API)Making each transport explicit helps users pick the right one for their use case.