Skip to content

Commit f065b76

Browse files
committed
minor #16920 [Form] Fix mistake about the reason of the limitation of the timestamp in 32bit systems (Deuchnord)
This PR was submitted for the 5.4 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Form] Fix mistake about the reason of the limitation of the timestamp in 32bit systems In the docs of the forms `DateType` field, we can read the following warning: > If `timestamp` is used, `DateType` is limited to dates between Fri, 13 Dec 1901 20:45:54 GMT and Tue, 19 Jan 2038 03:14:07 GMT on 32bit systems. This is due to a [limitation in PHP itself](https://www.php.net/manual/en/function.date.php#refsect1-function.date-changelog). The limitation is actually not specific to PHP, but related to the [Year 2038 problem](https://en.wikipedia.org/wiki/Year_2038_problem) that affects all 32bits systems. Just proposing a change to the docs to correct the information. :) (I'm sorry if it reminds another similar bug from the end of the last century 👀) <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- 50075b1 Fix mistake about the reason of the limitation of the timestamp in 32bit systems
2 parents c8d11fa + 50075b1 commit f065b76

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.. caution::
22

33
If ``timestamp`` is used, ``DateType`` is limited to dates between
4-
Fri, 13 Dec 1901 20:45:54 GMT and Tue, 19 Jan 2038 03:14:07 GMT on 32bit
5-
systems. This is due to a `limitation in PHP itself`_.
4+
Fri, 13 Dec 1901 20:45:54 UTC and Tue, 19 Jan 2038 03:14:07 UTC on 32bit
5+
systems. This is due to an integer overflow bug in 32bit systems known as the `Year 2038 problem`_.
66

7-
.. _limitation in PHP itself: https://www.php.net/manual/en/function.date.php#refsect1-function.date-changelog
7+
.. _Year 2038 problem: https://en.wikipedia.org/wiki/Year_2038_problem

0 commit comments

Comments
 (0)