Skip to content

[Form] Fix mistake about the reason of the limitation of the timestamp in 32bit systems #16920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

Deuchnord
Copy link

@Deuchnord Deuchnord commented Jun 27, 2022

In the docs of the forms DateType field, we can read the following warning:

If timestamp is used, DateType is limited to dates between Fri, 13 Dec 1901 20:45:54 GMT and Tue, 19 Jan 2038 03:14:07 GMT on 32bit systems. This is due to a limitation in PHP itself.

The limitation is actually not specific to PHP, but related to the Year 2038 problem that affects all 32bits systems.
Just proposing a change to the docs to correct the information. :)

(I'm sorry if it reminds another similar bug from the end of the last century 👀)

@Deuchnord Deuchnord requested a review from xabbuh as a code owner June 27, 2022 14:02
@carsonbot carsonbot added this to the 5.4 milestone Jun 27, 2022
@carsonbot carsonbot changed the title Fix mistake about the reason of the limitation of the timestamp in 32bit systems [Form] Fix mistake about the reason of the limitation of the timestamp in 32bit systems Jun 28, 2022
@javiereguiluz
Copy link
Member

Jérôme, thanks for improving this and congrats on your first Symfony Docs contribution 🎉

@javiereguiluz javiereguiluz merged commit f065b76 into symfony:4.4 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants