Skip to content

[Serializer] Add support for ignoring comments while XML encoding #10277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Sep 7, 2018 · 3 comments
Closed

[Serializer] Add support for ignoring comments while XML encoding #10277

javiereguiluz opened this issue Sep 7, 2018 · 3 comments
Labels
Serializer Stalled
Milestone
4.2

Comments

@javiereguiluz
Copy link
Member

See symfony/symfony#28289.
@javiereguiluz javiereguiluz added this to the 4.2 milestone Sep 7, 2018
@javiereguiluz javiereguiluz mentioned this issue Sep 7, 2018
Merged
@maxhelias maxhelias mentioned this issue Oct 9, 2020
Merged
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@carsonbot
Copy link
Collaborator

Just a quick reminder to make a comment on this. If I don't hear anything I'll close this.

wouterj added a commit that referenced this issue Jan 11, 2021
@wouterj
minor #14384 [Serializer] Add missing options context (maxhelias)
f1372f7 
This PR was merged into the 4.4 branch.

Discussion
----------

[Serializer] Add missing options context

The options are not really in the right place since just above the text indicates the elements for associative arrays.
But we only list context options for an associative array here : https://symfony.com/doc/current/components/serializer.html#context

Wouldn't we move all the options for all encoders here ? https://symfony.com/doc/current/components/serializer.html#encoders
And in the first section display only the possible options for associative array with the link to their description.

Solve #10277 and #10286

Commits
-------

159da02 Add missing options context
@wouterj
Copy link
Member

wouterj commented Jan 11, 2021

Fixed by #14384

@wouterj wouterj closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Serializer Stalled
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
3 participants
@javiereguiluz @wouterj @carsonbot