Skip to content

Broken link on the varnish cache page #16180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jdreesen opened this issue Dec 1, 2021 · 5 comments
Closed

Broken link on the varnish cache page #16180

jdreesen opened this issue Dec 1, 2021 · 5 comments
Labels
hasPR A Pull Request has already been submitted for this issue.

Comments

@jdreesen
Copy link
Contributor

jdreesen commented Dec 1, 2021

In symfony-docs/http_cache/varnish.rst there's a dead link which points to https://varnish-cache.org/trac/wiki/VCLExampleRemovingSomeCookies but now gets redirected to the Varnish home page.
@xabbuh
Copy link
Member

xabbuh commented Dec 2, 2021

Do you have an idea where we could link to instead?

@jdreesen
Copy link
Contributor Author

jdreesen commented Dec 2, 2021

Not right now, otherwise I would have created a PR ;)

Maybe I'll find something in the next days, as I'm a bit into the varnish topic at the moment.

@javiereguiluz javiereguiluz changed the title Dead link on the varnish cache page Broken link on the varnish cache page Dec 2, 2021
@jdreesen
Copy link
Contributor Author

jdreesen commented Dec 3, 2021

There doesn't seem to be a general page about cookies in the varnish docs.

There's for example this outdated one https://varnish-cache.org/docs/3.0/tutorial/cookies.html or this one from varnish plus https://www.varnish-software.com/wiki/content/tutorials/varnish/sample_vclTemplate.html#cookie-manipulation

Since v6.4 the cookie vmod is included, so there's this one in newer docs versions: https://varnish-cache.org/docs/7.0/reference/vmod_cookie.html

@javiereguiluz javiereguiluz mentioned this issue Jul 18, 2022
Merged
@javiereguiluz
Copy link
Member

@jdreesen I liked your last comment suggestion about the new docs, so I created #17007 to update the link. Thanks.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jul 19, 2022
javiereguiluz added a commit that referenced this issue Jul 19, 2022
@javiereguiluz
minor #17007 [HttpKernel] [HttpCache] Update a link to Varnish cookie…
8dde896 
… docs (javiereguiluz)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] [HttpCache] Update a link to Varnish cookie docs

Fixes #16180.

Commits
-------

0960134 [HttpCache] Update a link to Varnish cookie docs
@javiereguiluz
Copy link
Member

Fixed in #17007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @jdreesen @xabbuh