You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While the deprecation warnings are no longer there in DBAL 4, the DBAL documentation (updated in doctrine/dbal#5971) states that serverVersion should contain a full version number:
Please specify the full server version as the database server would report it. This is especially important for MySQL and MariaDB where the full version string is taken into account when determining the platform.
Should we update these examples to contain a full version number? It seems like the more recent Flex recipes for DoctrineBundle are already using full version numbers, compared to the older recipes.
I'm happy to send a PR, but I wanted to discuss this in an issue before submitting a PR.
This could be related to the following issues / PRs:
…l version numbers (nicwortel)
This PR was merged into the 5.4 branch.
Discussion
----------
[Doctrine] Replace serverVersion example values with full version numbers
Doctrine DBAL 3.6.0 deprecated incomplete version numbers for the serverVersion value (for example 8 or 8.0 for MySQL). Instead, a full version number (8.0.37) is expected.
See https://www.doctrine-project.org/projects/doctrine-dbal/en/4.0/reference/configuration.html#automatic-platform-version-detection and https://github.com/doctrine/dbal/blob/4.0.x/UPGRADE.md#bc-break-disallowed-partial-version-numbers-in-serverversion.
This commit replaces partial version numbers with full version numbers. It also replaces examples with EOL database versions (such as MySQL 5.7 and PostgreSQL 11) with more modern, supported versions.
Fixes#19876.
<!--
If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).
If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `7.x` for features of unreleased versions).
-->
Commits
-------
f3ac20e Replace serverVersion example values with full version numbers
Doctrine DBAL 3.6.0 deprecated incomplete version numbers for the
serverVersion
value (for example8
or8.0
for MySQL):While the deprecation warnings are no longer there in DBAL 4, the DBAL documentation (updated in doctrine/dbal#5971) states that
serverVersion
should contain a full version number:This is also supported by the UPGRADE.md:
However, most of the Symfony documentation I found still contains examples which configure the
DATABASE_URL
like this:...which seems to conflict with the Doctrine DBAL documentation.
For example:
Should we update these examples to contain a full version number? It seems like the more recent Flex recipes for DoctrineBundle are already using full version numbers, compared to the older recipes.
I'm happy to send a PR, but I wanted to discuss this in an issue before submitting a PR.
This could be related to the following issues / PRs:
The text was updated successfully, but these errors were encountered: