Skip to content

Renaming "Securing Individual Objects" #13553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

ThomasLandauer
Copy link
Contributor

Reason: I never understood what "objects" referred to in "Securing Individual Objects". Renaming it to "Individual User Permissions" is another step forward at solving the "discoverability" problem I mentioned in #11505

However, I would still move it higher up on the page (above Roles), since I see it like this: Having Individual users is basic for any security system; grouping those users into something called Roles is advanced.

Second, since Voters are described on a separate page, I would also defer Roles to another page, off the main security page.

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot, this makes sense to me. I wasn't happy with the title either, but couldn't come up with a better alternative.

About the location of this section: the whole security chapter (as you also mentioned in another issue) asks very much to be reconsidered. It's on my list, first I want to bring some improvements to the code and then improve the documentations (directly applying the code improvements).

So this is just a first step to make the chapter iteratively better. The ACL stuff was completely out-of-place, this "object" thing is as well. For now, the structure of the article forces this location: It discusses Security attributes and roles at the same time. We can't put voters before it, as voters require understanding Security attributes. So in a future iteration, I want to first rewrite the previous section to describe Security attributes without roles. From there, we can continue to change the roles and voters sections.

I'll keep you posted & thanks for reporting and thinking with us! Even though some things are now closed without being implemented, I take them into account when working on future iterations.

@wouterj
Copy link
Member

wouterj commented Apr 16, 2020

Thanks again!

@wouterj wouterj merged commit 63543e8 into symfony:4.4 Apr 16, 2020
@ThomasLandauer ThomasLandauer deleted the patch-13 branch April 16, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants