Adding docs around the new "css" Encore functions and disabling file tracking #13652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
force-pushed
the
encore_source_css
branch
from
c754f00 to
1990989
Compare
OskarStark
reviewed
May 11, 2020
Contributor
OskarStark
left a comment
OskarStark
left a comment
There was a problem hiding this comment.
Do we need a versionadded directive?
| {{ encore_entry_js_source('my_entry')|raw }} | ||
| </script> | ||
|
|
||
| If you can't use these `encore_entry_*_source` functions, you can instead |
Contributor
There was a problem hiding this comment.
Double backticks please
wouterj
reviewed
Oct 22, 2020
|
|
||
| * :doc:`Using Bootstrap CSS & JS </frontend/encore/bootstrap>` | ||
| * :doc:`Creating Page-Specific CSS/JS </frontend/encore/page-specific-assets>` | ||
| * :doc:`Rendering Multiple Templates in a Request: Emails, PDFs </frontend/encore/file-tracking>` |
Member
There was a problem hiding this comment.
Why aren't we doing :doc:`/frontend/encore/file-tracking` here? :)
| {{ encore_entry_script_tags('entry1') }} | ||
| {% do encore_enable_file_tracking() %} | ||
|
|
||
| With this, *all* JS and CSS files for `entry1` will be rendered and |
Member
There was a problem hiding this comment.
Suggested change
| With this, *all* JS and CSS files for `entry1` will be rendered and | |
| With this, *all* JS and CSS files for ``entry1`` will be rendered and |
| bundle re-renders CSS or JS files that it previously rendered. For | ||
| example, in a controller:: | ||
|
|
||
|
|
|
|
||
|
|
||
| // src/Controller/SomeController.php | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| namespace App\Controller; | |
| public function index(EntrypointLookupInterface $entrypointLookup) | ||
| { | ||
| $entrypointLookup->reset(); | ||
| // render a template |
Member
There was a problem hiding this comment.
Suggested change
| // render a template | |
| // ... render a template |
| // render a template | ||
|
|
||
| $entrypointLookup->reset(); | ||
| // render another template |
Member
There was a problem hiding this comment.
Suggested change
| // render another template | |
| // ... render another template |
Member
|
Let's close this old pending PR because we're moving away from Webpack Encore very fast so it doesn't make sense to try to add new complex features like this one. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Docs for symfony/webpack-encore-bundle#91
Cheers!