Describe how to get a stack trace with Symfony #13699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
force-pushed
the
getting-a-stack-trace
branch
4 times, most recently
from
2f1068a to
357a6b6
Compare
|
@OskarStark can you please help DOCtor-RST? I think there is an issue with https://github.com/OskarStark/doctor-rst/blob/e4b46021e110dc5aed0ee62d6513a61ab9ebf64f/src/Rule/PhpPrefixBeforeBinConsole.php , it shouldn't report |
greg0ire
force-pushed
the
getting-a-stack-trace
branch
from
0b9f7f7 to
bd4dc4c
Compare
|
I made a PR to doctor-RST: OskarStark/doctor-rst#697 |
|
Aaaaand fixed :) |
faizanakram99
approved these changes
Jun 20, 2020
greg0ire
force-pushed
the
getting-a-stack-trace
branch
from
f2e4f57 to
65f1e89
Compare
greg0ire
force-pushed
the
getting-a-stack-trace
branch
from
65f1e89 to
7030dc1
Compare
|
@noniagriconomie I noticed today that I had local changes to address your comments that I had not commited. Please review again and mark discussions as resolved if they are indeed resolved. |
noniagriconomie
approved these changes
Sep 7, 2020
OskarStark
reviewed
Sep 7, 2020
There was a problem hiding this comment.
Only some minor comments.
@symfony/team-symfony-docs I am 👍🏻 for merging it. It brings additional understanding and help for new developers.
Thank you for the time to write this down @greg0ire🙏
greg0ire
force-pushed
the
getting-a-stack-trace
branch
from
7030dc1 to
5e4f9b7
Compare
OskarStark
approved these changes
Sep 20, 2020
xabbuh
approved these changes
Sep 20, 2020
greg0ire
force-pushed
the
getting-a-stack-trace
branch
2 times, most recently
from
f3a10cc to
9f42830
Compare
As a maintainer, I often struggle to get stack traces in bug reports. I miss a good resource to describe how to do it with Symfony. This aims at showing developers how to do that, but also to help them understand more about stack traces.
xabbuh
force-pushed
the
getting-a-stack-trace
branch
from
9f42830 to
d0a97ae
Compare
|
Thank you @greg0ire. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a maintainer, I often struggle to get stack traces in bug reports. I
miss a good resource to describe how to do it with Symfony. This aims at
showing developers how to do that, but also to help them understand more
about stack traces.
This PR does not fix a bug, nor does it document a new feature, so I'm not sure which branch I should target here.