[HttpClient] Update http_client.rst #14499
Conversation
I started from scratch after symfony#14174 * The most important change is that the old text "your code is expected to handle it" didn't make it clear *how* people are supposed to handle it. * I omitted the note that a `Symfony\Component\HttpClient\Exception\ClientException` is thrown. Is this important? Or is the existing `Symfony\\Contracts\\HttpClient\\Exception\\HttpExceptionInterface` enough?
|
@nicolas-grekas Please review |
http_client.rst
Outdated
|
|
||
| $response = $client->request('GET', 'https://httpbin.org/status/403'); | ||
| if (403 === $response->getStatusCode()) { | ||
| $response->getContent(); |
There was a problem hiding this comment.
This will throw.
Checking the status code disables throwing by the destructor only.
The behavior of the other methods is always predictable and controlled by the $throw argument.
I agree we should find a better way to explain all this :)
There was a problem hiding this comment.
Damn, I checked for string '403', while in fact it's int...
Please take a look again!
And if you still have some nerves left: :-)
Maybe it would be easier to get across when we could explain the idea behind it! The $throw argument is straightforward. But why did you do the destructor / getStatusCode() thing? What use cases did you have in mind?
And one more: For those 3 methods together (getHeaders(), getContent() and toArray()), do you have some internal (nick) name we could use? Something like "contentFetchers" or so?
There was a problem hiding this comment.
Ping @nicolas-grekas :-)
There was a problem hiding this comment.
@nicolas-grekas Could you please merge this, before it ages away? :-)
|
@nicolas-grekas OK, thanks, included everything :-) |
@nicolas-grekas Identical copy of symfony#14499
|
Closing in favor of #16141, since I don't know how to rebase ;-) |
I started from scratch after #14174
Symfony\Component\HttpClient\Exception\ClientExceptionis thrown. Is this important? Or is the existingSymfony\\Contracts\\HttpClient\\Exception\\HttpExceptionInterfaceenough?