Fix user entity import #14547
Closed
Fix user entity import #14547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user entity import was incorrectly set to import from the Security namespace instead of Entity.
Arman-Hosseini
approved these changes
Nov 14, 2020
Comment on lines
24
to
-26
| namespace App\Security; | ||
|
|
||
| use App\Security\User as AppUser; |
There was a problem hiding this comment.
Why not referred to AppBundle and use AppBundle\Exception\AccountDeletedException; was also lost?
There was a problem hiding this comment.
Sorry, this was my mistake, I was on 3.4 branch.
Arman-Hosseini
approved these changes
Nov 14, 2020
|
Thanks for this fix @obsirdian. However, in #14546 you did the same change and that's enough, so we're closing this pull request. Because of how Symfony Docs repository works, you only have to make the fix in the oldest maintained branch that contains the bug. Then we merge the same fix in all supported branches. So, closing this then. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user entity import was incorrectly set to import from the Security namespace instead of Entity.
https://symfony.com/doc/current/security/user_checkers.html