Skip to content

[Console] Update table.rst #14645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2020
Merged

[Console] Update table.rst #14645

merged 1 commit into from
Dec 9, 2020

Conversation

sebpacz
Copy link
Contributor

@sebpacz sebpacz commented Dec 3, 2020

The Symfony\Component\Console\Helper\TableStyle class doesn't have the setDefaultCrossingChars method. I removed all references to this method.

The Symfony\Component\Console\Helper\TableStyle class doesn't have the setDefaultCrossingChars method, but there is the setCrossingChars method. The setCrossingChars method takes at least 9 parameters, so I think it would be difficult to present it in the example instead of the setDefaultCrossingChars method. In this commit, I removed all references to the method that doesn't exist.
@wouterj
Copy link
Member

wouterj commented Dec 9, 2020

Thank you Sebastian! You're correct that this method does not exists. While searching through the git history, I discovered that they probably meant setHorizontalBorderChars instead of crossing chars. I've updated your PR accordingly and merged it :)

@wouterj wouterj merged commit 81d633b into symfony:4.4 Dec 9, 2020
@sebpacz sebpacz deleted the patch-3 branch December 30, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants