Skip to content

[Validator] Mention IsNull in Basic Constraints #15028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Feb 24, 2021

Email, Date, File and other string constraints have note:

As with most of the other constraints, null and empty strings are considered valid values. This is to allow them to be optional values. If the value is mandatory, a common solution is to combine this constraint with NotBlank.

This pull request adds a note about null to Basic Constraints. Empty/Blank string is an invalid value for them. That's why I added a new note.

Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition to me 👍

@javiereguiluz
Copy link
Member

Yes, I agree this is better. Thanks!

@javiereguiluz javiereguiluz merged commit 3ff1ecf into symfony:4.4 Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants