Skip to content

[Form] [Form Theme] customize choice entry #15921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7,584 commits into from

Conversation

gilles-g
Copy link
Contributor

Hi,

I'm not sure if I have add my text on the right file..

My english is not good as you ;)

@carsonbot carsonbot added this to the 4.4 milestone Oct 13, 2021
@gilles-g gilles-g changed the title [FORM THEME] customize choice entry [Form Theme] customize choice entry Oct 13, 2021
@gilles-g
Copy link
Contributor Author

gilles-g commented May 9, 2022

@javiereguiluz Any update about this?

javiereguiluz and others added 26 commits September 27, 2022 17:45
* 6.1:
  Trying to add quotation markup
* 4.4:
  Fix use statement
* 5.4:
  Fix use statement
* 6.0:
  Fix use statement
* 6.1:
  Fix use statement
* 4.4:
  Remove reference to a removed configuration key
* 5.4:
  Remove reference to a removed configuration key
* 6.0:
  Remove reference to a removed configuration key
* 6.1:
  Remove reference to a removed configuration key
* 4.4:
  [Workflow] fix image labels
* 5.4:
  [Workflow] fix image labels
* 6.0:
  [Workflow] fix image labels
* 6.1:
  [Workflow] fix image labels
…rs (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Mailer] remove display names from envelope headers

Commits
-------

69d06ff remove display names from envelope headers
* 5.4:
  remove display names from envelope headers
  Fix use statement
  Remove reference to a removed configuration key
  [Workflow] fix image labels
* 6.0:
  remove display names from envelope headers
* 6.1:
  remove display names from envelope headers
* 4.4:
  Improve the diff highlighting for custom webpack plugins
* 5.4:
  Improve the diff highlighting for custom webpack plugins
* 6.0:
  Improve the diff highlighting for custom webpack plugins
* 6.1:
  Improve the diff highlighting for custom webpack plugins
* 4.4:
  [DependencyInjection] Add a section for testing service subscribers
* 5.4:
  [DependencyInjection] Add a section for testing service subscribers
* 6.0:
  [DependencyInjection] Add a section for testing service subscribers
javiereguiluz and others added 23 commits October 19, 2022 17:11
This PR was merged into the 5.4 branch.

Discussion
----------

[Notifier] Update FreeMobile DSN

PR to reflect changes from [symfony/symfony/47915](symfony/symfony#47915)

Commits
-------

b532f37 [Notifier] Update FreeMobile DSN
…ontext in mapping (ogizanagi)

This PR was merged into the 5.4 branch.

Discussion
----------

[Serializer] Allow to provide (de)normalization context in mapping

Fixes symfony#14988

Commits
-------

800017d [Serializer] Allow to provide (de)normalization context in mapping
* 5.4:
  [Notifier] Update FreeMobile DSN
  [Serializer] Allow to provide (de)normalization context in mapping
* 6.0:
  [Notifier] Update FreeMobile DSN
  [Serializer] Allow to provide (de)normalization context in mapping
* 6.1:
  [Notifier] Update FreeMobile DSN
  [Serializer] Allow to provide (de)normalization context in mapping
…tored (ThomasLandauer)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Security] Adding info where login attempts are stored

Commits
-------

7ad5d9f [Security] Adding info where login attempts are stored
* 5.4:
  [Security] Adding info where login attempts are stored
* 6.0:
  [Security] Adding info where login attempts are stored
* 6.1:
  [Security] Adding info where login attempts are stored
This PR was merged into the 5.4 branch.

Discussion
----------

[Serializer] Fixup attributes import

Re-reading the rendered doc at https://symfony.com/doc/5.4/serializer.html#serializer-context, spotted I missed this.

Commits
-------

34881a8 [Serializer] Fixup attributes import
* 5.4:
  [Serializer] Fixup attributes import
* 6.0:
  [Serializer] Fixup attributes import
* 6.1:
  [Serializer] Fixup attributes import
…actor (welcoMattic)

This PR was merged into the 6.2 branch.

Discussion
----------

[Translation] Add new cases covered by PhpAstExtractor

In symfony/symfony#46161, we rewrite the PHP Translation extractor. It covers more cases, like named arguments.
Documentation needed to be updated consequently.

Commits
-------

5029cb2 Add new cases covered by PhpAstExtractor
…ce by ValueResolverInterface (wouterj)

This PR was merged into the 6.2 branch.

Discussion
----------

[HttpKernel] Replace ArgumentValueResolverInterface by ValueResolverInterface

Fixes symfony#17225

I've also updated the example using a different example (one we use frequently in our projects). The issue with the current example is that it re-implements something that was already built-in, requiring all sorts of workarounds.

cc `@nicolas`-grekas

Commits
-------

b6bcc3d [HttpKernel] Replace ArgumentValueResolverInterface by ValueResolverInterface
…hiddewie)

This PR was squashed before being merged into the 6.2 branch.

Discussion
----------

Use `addPart` instead of `embed*` or `attach*`.

Fixes symfony#17303
Ref symfony#17353
Ref symfony/symfony#47711
Ref symfony/symfony#47462

This PR contains the documentation for simplifications for adding parts to `Email`s.

Commits
-------

ebbffc5 Use `addPart` instead of `embed*` or `attach*`.
@gilles-g
Copy link
Contributor Author

Hum, never ever click on "sync branch in your fork", I will recreate a PR with your recommendations @HeahDude :D

@HeahDude
Copy link
Contributor

@Spike31 if you have symfony as a remote you can try git pull --rebase symfony 4.4 or git rebase -i symfony/4.4.

@gilles-g gilles-g closed this Oct 21, 2022
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Oct 26, 2022
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Form][Form Choice] customize choice entry

First PR here symfony#15921, but...something happened!

I'm not sure where to add the link on the form_theme document, so I don't add it.

And I'm not sure for the title **Access data in a Form Choice**

`@HeahDude`

Commits
-------

8a05949 [Form][Form Choice] customize choice entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.