Clarify & expand service decoration description #16161
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also added an `App\\Mailer` namespace to all code examples.
|
@javiereguiluz Pinging for a review when you have time. 🙏 😄 |
OskarStark
reviewed
Nov 28, 2021
|
@nicolas-grekas would you have some time to review this PR ? Thanks |
@OskarStark Thank you for the review! I added the sub Mailer namespace because that's how it would normally be coded (best practice). We would not put the |
|
I'm closing this PR and redoing it because I forgot to create separate fix branches. That's basically preventing me from creating separate new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added an App\Mailer namespace to all code examples.