Skip to content

[Serializer] Fix invalid statement about normalizers #16371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2022

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Jan 5, 2022

Not all normalizers are enabled by default, e.g. the GetSetMethodNormalizer isn't.

I've moved the example of how to enable additional normalizers to components/serializer.rst, serializer.rst already has a link to it on line 70.

- not all normalizers are enabled by default
@javiereguiluz
Copy link
Member

Thanks @HypeMC.

@javiereguiluz javiereguiluz merged commit 7b083f6 into symfony:4.4 Jan 7, 2022
@HypeMC HypeMC deleted the enabled-normalizers-fix branch January 7, 2022 17:31
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jan 11, 2022
This PR was merged into the 5.3 branch.

Discussion
----------

[Serializer] Reintroduce removed note

Followup to symfony#16371

This note is present on the [4.4 branch](https://github.com/symfony/symfony-docs/blob/7b083f6118d6aa2649613a0bc54ba7eadcee1c79/components/serializer.rst?plain=1#L799-L802) but was removed on the 5.x branch with symfony#14799 .

Since there is no other link to the custom normalizer docs on this page, I'd suggest adding it back. Also, this would make it consistent with the [Encoders section](https://github.com/symfony/symfony-docs/blob/09b9115337070d1adb69c22eaffa46c635da17d5/components/serializer.rst?plain=1#L999-L1002).

Commits
-------

d5cbaf4 Reintroduce removed note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants