[WIP] Integrating UX docs more closely into Symfony docs #16404
Conversation
There was a problem hiding this comment.
This is great, thanks Ryan! The stream of awesome contributions from you just doesn't stop the past months :)
Two other points:
- Let's update the "Symfony UX initiative" link in the form type reference to point to
/frontend/ux - Please rebase this PR to remove the merge commit
carsonbot
added
Status: Reviewed
and removed
Status: Needs Work
Status: Needs Review
labels
…y.com (weaverryan) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [WIP] Refactoring all docs to .rst files to host on symfony.com | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Tickets | None | License | MIT This preps the docs so that they can be hosted on symfony.com/bundles. TODO: * [X] a partner PR on symfony-docs to update some URLs and other things there symfony/symfony-docs#16404 * [x] Javier to be ready to integrate this into symfony.com after merge Commits ------- 71a9db3 Merge branch '2.x' into rst_docs e6aeda3 minor docs tweaks 604f177 delegating most of main README to Symfony docs 86ba8ab linking to new UX section fb05d24 Refactoring all docs to .rst files to host on symfony.com
|
Ready to go again :) |
weaverryan
force-pushed
the
ux-docs-in-bundles-section
branch
from
3631213 to
6ed2e71
Compare
|
Thanks @weaverryan! Is there a reason to target 5.4 here, instead of 5.3 or 4.4? Afaik, UX is available in all versions :) |
|
Just that we, I think, typically target the "current Symfony version" for new docs, right? To avoid extra pain merging up from old branches? But certainly, I could target something older. WDYT? |
|
Ryan, I understand what you say ... but we always merge UX things in 4.4 because they are disconnected from Symfony versioning. Note that if, for any reason, it's complicated for us to write these docs for 4.4, we can change this practice. Thanks! |
weaverryan
force-pushed
the
ux-docs-in-bundles-section
branch
from
6ed2e71 to
0fcdb32
Compare
weaverryan
force-pushed
the
ux-docs-in-bundles-section
branch
from
0fcdb32 to
ba6ac09
Compare
|
Note that I wanted to merge this in 5.3 yesterday (4.4 gave lots of conflicts) and then discovered that Turbo and "Stimulus & Symfony UX" also wasn't merged in 5.3. As far as I know, we've only applied the practice to only update the latest version for a very brief time and are updating older versions again. EDIT: removed the demotivating text as you've updated this PR to target 4.4 already 🚀 :) |
|
No problem - it seems very pragmatic :). As you mentioned, some things didn't exist on 4.4. So But, this should be ready I think :) |
weaverryan
force-pushed
the
ux-docs-in-bundles-section
branch
from
2d666a1 to
4177f81
Compare
This PR was merged into the 5.4 branch. Discussion ---------- [4.4][UX] Removing extra links from rebasing Hi! I merged #16404 a bit too quickly. I had rebased that from 5.4 to 4.4, and when I did, I duplicated a few things that I should not have. This fixes that :). Cheers! Commits ------- c6d8d26 Removing extra links from rebasing
…y.com (weaverryan) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [WIP] Refactoring all docs to .rst files to host on symfony.com | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Tickets | None | License | MIT This preps the docs so that they can be hosted on symfony.com/bundles. TODO: * [X] a partner PR on symfony-docs to update some URLs and other things there symfony/symfony-docs#16404 * [x] Javier to be ready to integrate this into symfony.com after merge Commits ------- 71a9db3 Merge branch '2.x' into rst_docs e6aeda3 minor docs tweaks 604f177 delegating most of main README to Symfony docs 86ba8ab linking to new UX section fb05d24 Refactoring all docs to .rst files to host on symfony.com
Hi!
Partner to symfony/ux#225
TODO