Skip to content

Update README.markdown #16530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2022
Merged

Update README.markdown #16530

merged 1 commit into from
Feb 21, 2022

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Feb 20, 2022

@carsonbot carsonbot added this to the 5.4 milestone Feb 20, 2022
OskarStark
OskarStark reviewed Feb 20, 2022
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence is not true anymore while 5.4 is the lowest branch

wouterj
wouterj approved these changes Feb 21, 2022
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.4 is still maintained for a year

@94noni 94noni changed the base branch from 5.4 to 4.4 February 21, 2022 11:48
@94noni 94noni requested a review from xabbuh as a code owner February 21, 2022 11:48
@94noni 94noni changed the base branch from 4.4 to 5.4 February 21, 2022 11:49
@94noni
Copy link
Contributor Author

94noni commented Feb 21, 2022

yes that is why I write 5.4 :)
but I just saw I target 5.4 not 4.4, and if I change the branch on github gui there are tons of fails
can you back port it or should I close and reopen on 4.4 ? thx

@javiereguiluz
Copy link
Member

Thank you Antoine.

@javiereguiluz javiereguiluz merged commit b5857d7 into symfony:5.4 Feb 21, 2022
@94noni 94noni deleted the patch-9 branch February 21, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@94noni @javiereguiluz @wouterj @OskarStark @carsonbot