[Filesystem] Update filesystem.rst #16531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
added
Filesystem
Status: Reviewed
and removed
Status: Needs Review
labels
Hello, According to the `getLongestCommonBasePath` signature, the method accepts a variadic string parameter $paths and not an array. It means when calling the `Path::getLongestCommonBasePath` with an array, a `TypeError` occurs. I think even the PHPDoc of the `Path::getLongestCommonBasePath` should be updated too as it is mentionned that it can accept an array argument.
javiereguiluz
force-pushed
the
patch-5
branch
from
09d9b41 to
2ebec3b
Compare
|
Good catch, thanks Issam. |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Feb 21, 2022
…reguiluz) This PR was merged into the 5.4 branch. Discussion ---------- [Filesystem] Update some PHPDoc of the Path class | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Originally discovered by `@issamkhadiri1989` in the Symfony Docs PR symfony/symfony-docs#16531 Commits ------- d27eab5 [Filesystem] Update some PHPDoc of the Path class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
According to the
getLongestCommonBasePathsignature, the method accepts a variadic string parameter $paths and not an array. It means when calling thePath::getLongestCommonBasePathwith an array, aTypeErroroccurs.I think even the PHPDoc of the
Path::getLongestCommonBasePathshould be updated too as it is mentionned that it can accept an array argument.