Skip to content

[DependencyInjection][Framework] kernel.locale_aware #16639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

[DependencyInjection][Framework] kernel.locale_aware #16639

merged 1 commit into from
Oct 26, 2022

Conversation

Guikingone
Copy link
Contributor

Hi 👋🏻

It seems that the kernel.locale_aware tag was introduced in 4.3 without documenting it, here's a first draft.

Thanks for the feedback 🙂

@Guikingone Guikingone changed the title refactor(reference): document kernel.locale_aware [FRAMEWORK] - kernel.locale_aware Mar 23, 2022
@Guikingone Guikingone changed the title [FRAMEWORK] - kernel.locale_aware [Framework] - kernel.locale_aware Mar 23, 2022
@carsonbot
Copy link
Collaborator

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.4, 6.0, 6.1.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 4.3 milestone Mar 23, 2022
94noni
94noni reviewed Mar 27, 2022
View reviewed changes
HeahDude
HeahDude reviewed Sep 25, 2022
View reviewed changes
@xabbuh xabbuh modified the milestones: 4.3, 4.4 Sep 26, 2022
@carsonbot carsonbot changed the title [Framework] - kernel.locale_aware [DependencyInjection] [Framework] - kernel.locale_aware Oct 26, 2022
@OskarStark OskarStark changed the title [DependencyInjection] [Framework] - kernel.locale_aware [DependencyInjection][Framework] kernel.locale_aware Oct 26, 2022
@javiereguiluz javiereguiluz changed the base branch from 4.3 to 4.4 October 26, 2022 10:25
@javiereguiluz
Copy link
Member

Thank you Guillaume.

@javiereguiluz javiereguiluz merged commit de881b3 into symfony:4.4 Oct 26, 2022
@javiereguiluz
Copy link
Member

Merged in 4.4 and up. thanks to all reviewers! I added most of your suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz javiereguiluz left review comments

@94noni 94noni 94noni left review comments

@HeahDude HeahDude HeahDude left review comments

Assignees
No one assigned
Labels
DependencyInjection Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@Guikingone @carsonbot @javiereguiluz @94noni @HeahDude @xabbuh