Skip to content

Use JsonResponse/BinaryFileResponse instead of Response #16752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2022
Merged

Use JsonResponse/BinaryFileResponse instead of Response #16752

merged 1 commit into from
Apr 29, 2022

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Apr 25, 2022

Use JsonResponse/BinaryFileResponse as return type when json/file methods are used

@carsonbot carsonbot added this to the 5.4 milestone Apr 25, 2022
@l-vo l-vo changed the base branch from 5.4 to 4.4 April 25, 2022 14:02
@l-vo l-vo requested review from xabbuh and OskarStark as code owners April 25, 2022 14:02
@l-vo l-vo changed the base branch from 4.4 to 5.4 April 25, 2022 14:02
@l-vo
Use JsonResponse/BinaryFileResponse instead of Response
18d9b73 
Use JsonResponse/BinaryFileResponse as return type when json/file methods are used
@l-vo l-vo changed the base branch from 5.4 to 4.4 April 25, 2022 14:07
@javiereguiluz javiereguiluz modified the milestones: 5.4, 4.4 Apr 29, 2022
@javiereguiluz
Copy link
Member

Yes, this is more precise. I like it. Thanks Laurent.

@javiereguiluz javiereguiluz merged commit 677835a into symfony:4.4 Apr 29, 2022
@l-vo l-vo deleted the l-vo-patch-1 branch April 30, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@l-vo @javiereguiluz @carsonbot