Skip to content

[Security] Creating a route for logout is always required even if the default value is used #16796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2022

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented May 10, 2022

According to https://symfony.com/doc/current/security.html#logging-out and the fact that there is no default logout route defined in Symfony (at least I didn't find one).

Even if the default value is used
@carsonbot carsonbot added this to the 5.4 milestone May 10, 2022
@javiereguiluz javiereguiluz requested a review from wouterj May 10, 2022 15:50
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is indeed a correct change. A known limitation (and one I would love to be able to remove) from running after Symfony's router.

@carsonbot carsonbot changed the title Creating a route for logout is always required even if the default value is used [Security] Creating a route for logout is always required even if the default value is used May 13, 2022
@javiereguiluz
Copy link
Member

Thank you Laurent.

@javiereguiluz javiereguiluz merged commit c014ad1 into symfony:5.4 May 13, 2022
@l-vo l-vo deleted the patch-11 branch May 13, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants