Skip to content

[Security] Fix typehint in custom user provider #16797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2022
Merged

[Security] Fix typehint in custom user provider #16797

merged 1 commit into from
May 16, 2022

Conversation

norkunas
Copy link
Contributor

No description provided.

@javiereguiluz javiereguiluz requested a review from wouterj May 13, 2022 15:28
@wouterj wouterj added this to the 5.4 milestone May 13, 2022
wouterj
wouterj approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(note for the mergers: this can be merged in 5.4)

@javiereguiluz javiereguiluz changed the base branch from 6.0 to 5.4 May 16, 2022 15:48
@javiereguiluz javiereguiluz requested a review from xabbuh as a code owner May 16, 2022 15:48
@javiereguiluz
Copy link
Member

Good catch, thanks Tomas.

@javiereguiluz javiereguiluz merged commit 7cfe1de into symfony:5.4 May 16, 2022
@norkunas norkunas deleted the fix-typehint branch May 16, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Security Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@norkunas @javiereguiluz @wouterj @carsonbot