[Serializer] Update serializer.rst #16845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello The `$encoderIgnoredNodeTypes` does not exist in the XmlEncoder's constructor and the $defaultContext argument should be used instead, So To escape the comments while encoding, we can either pass the `\XML_COMMENT_NODE` to the `XmlEncoder::ENCODER_IGNORED_NODE_TYPES` context option in the constructor or use it when calling the encode() method.
HeahDude
reviewed
Jun 9, 2022
javiereguiluz
added
Status: Reviewed
Serializer
and removed
Status: Needs Review
labels
|
Thanks @issamkhadiri1989 for this contribution ... and thanks Jules for the review. I made all the requested changes while merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
The
$encoderIgnoredNodeTypesdoes not exist in the XmlEncoder's constructor and the $defaultContext argument should be used instead, So To escape the comments while encoding, we can either pass the\XML_COMMENT_NODEto theXmlEncoder::ENCODER_IGNORED_NODE_TYPEScontext option in the constructor or use it when calling the encode() method.