[EventDispatcher] Document dispatch() with one argument as a FQCN #17035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94noni
changed the title
javiereguiluz
added a commit
to symfony/demo
that referenced
this pull request
Nov 2, 2023
This PR was merged into the main branch. Discussion ---------- Add notice to messenger for async code While reading this, I found that pointing messenger here can be valuable (logic of decoupling) Also, reading the code itself of the dispatch, I remind my old PR symfony/symfony-docs#17035 there is no doc referencing the new `->dispatch(new ClassName())` as far as I see in https://symfony.com/doc/current/components/event_dispatcher.html#dispatch-the-event Commits ------- 3b7a46d Add notice to messenger for async code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revisit this one
I reminded it due to working on this one
Original PR desc
Related to https://symfony.com/blog/new-in-symfony-4-3-simpler-event-dispatching
Feature introduced in symfony/symfony#28920
Maybe it is useful/helpful to document this here as well as the blog post