Skip to content

[RateLimiter] Adding info about clearing cache #17136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

ThomasLandauer
Copy link
Contributor

I'm just guessing this - please double-check!

I'm just *guessing* this - please double-check!
@carsonbot carsonbot added this to the 5.4 milestone Aug 9, 2022
@ThomasLandauer
Copy link
Contributor Author

Just reading on https://symfony.com/doc/current/security/login_link.html#configure-a-maximum-use-of-a-link that the cache is not cleared:

The cache pools are not cleared by the cache:clear command, but removing var/cache/ manually may remove the cache if the cache component is configured to store its cache in that location.

So the solution is maybe to just include the same info on this page too.

@alexislefebvre
Copy link
Contributor

Can these cache pools be cleared with bin/console cache:pool:clear? See https://symfony.com/doc/current/cache.html#clearing-the-cache

@ThomasLandauer
Copy link
Contributor Author

When I'm doing cache:clear (as recommended at https://symfony.com/doc/5.4/deployment.html#d-clear-your-symfony-cache), I'm getting the login_throttling counter reset. So at https://symfony.com/doc/5.4/security.html#limiting-login-attempts it should also be explained, that the counter will be reset on every deploy.
Can somebody confirm this?

@carsonbot carsonbot changed the title Adding info about clearing cache [Security] Adding info about clearing cache Oct 18, 2022
@carsonbot carsonbot changed the title [Security] Adding info about clearing cache [RateLimiter] Adding info about clearing cache Oct 18, 2022
@javiereguiluz
Copy link
Member

Thanks Thomas.

@javiereguiluz javiereguiluz merged commit 5c68371 into symfony:5.4 Oct 18, 2022
@ThomasLandauer ThomasLandauer deleted the patch-14 branch October 18, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants