[Console] Create consistent console screenshots/recordings #17271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
force-pushed
the
console-gifs
branch
2 times, most recently
from
dd7f59e to
23160aa
Compare
|
Thanks for contributing this improvement and thanks for the effort you put on it. I like the overall consistency and also that we have the sources of the recordings as editable text. About the missing one, do you want to wait until you find a solution for it or do you think we could merge this now and try to fix the missing recording in a later PR? Thanks. |
wouterj
force-pushed
the
console-gifs
branch
2 times, most recently
from
aa1b9eb to
f310739
Compare
|
Thanks Javier. I've just finished this PR:
|
wouterj
force-pushed
the
console-gifs
branch
from
f310739 to
8bd5eef
Compare
|
It's merged! Thanks Wouter!! |
|
Great work, thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The, honestly quite minor, issue with inconsistent terminal screenshots/recordings has been bugging me for quite some time. When creating the recording for my most recent console PR, I managed to get something set-up that can be replicated by others - although the rendering is a bit tricky.
The only remaining recording is the progress bar. At the moment, my terminal emulator crashes when displaying emoji's, so I have some trouble creating the asciicast file for it 😄
The color scheme is based on the dark theme terminal color scheme in the Symfony docs. I'm not totally convinced about the green color, which is too dark when used as foreground but the bright one is too light when used as background. If someone has a better suggestion, please let me know