Skip to content

[PropertyInfo] Add ConstructorExtractor documentation for 6.2 (with CPP) #18162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

[PropertyInfo] Add ConstructorExtractor documentation for 6.2 (with CPP) #18162

merged 1 commit into from
Apr 6, 2023

Conversation

alexandre-daubois
Copy link
Member

Follow-up of #18161

@alexandre-daubois alexandre-daubois force-pushed the constructor-extractor-6.2 branch 2 times, most recently from c1d06cd to 378ad98 Compare April 5, 2023 13:15
@OskarStark
Copy link
Contributor

Rebase unlocked ✅

OskarStark
OskarStark reviewed Apr 6, 2023
View reviewed changes
components/property_info.rst Outdated
Comment on lines 525 to 524
public function __construct(private string $bar)
{
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function __construct(private string $bar)
{
}
public function __construct(
private string $bar,
) {
}

@alexandre-daubois alexandre-daubois force-pushed the constructor-extractor-6.2 branch from 378ad98 to 7bc15b6 Compare April 6, 2023 06:56
@alexandre-daubois alexandre-daubois force-pushed the constructor-extractor-6.2 branch from 7bc15b6 to 5bc0bec Compare April 6, 2023 06:57
@alexandre-daubois
Copy link
Member Author

Rebased! 🙂

@OskarStark
Copy link
Contributor

Thank you @alexandre-daubois.

@OskarStark OskarStark merged commit 5ee7b8f into symfony:6.2 Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

Assignees
No one assigned
Labels
PropertyInfo Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-daubois @OskarStark @carsonbot