[Mailer] Document the optional HttpClient dependency #18387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 8, 2023
derrabus
reviewed
Jun 8, 2023
mailer.rst
Outdated
Comment on lines
134
to
135
| When using a 3rd party transport, you might want to use a web API | ||
| instead of directly rely on the SMTP protocol to send emails. |
There was a problem hiding this comment.
This sounds a bit like we preferred web APIs over SMTP. I had something more neutral in mind, like…
Suggested change
| When using a 3rd party transport, you might want to use a web API | |
| instead of directly rely on the SMTP protocol to send emails. | |
| Besides SMTP, many 3rd party transports offer a web API to send emails. |
alexandre-daubois
force-pushed
the
optional-http-client
branch
from
136ecbe to
5027017
Compare
OskarStark
reviewed
Jun 8, 2023
alexandre-daubois
force-pushed
the
optional-http-client
branch
from
5027017 to
7ecb253
Compare
xabbuh
approved these changes
Jun 8, 2023
|
Thanks Alex for this nice contribution and thanks a lot to reviewers too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18386