[Testing] [Panther] Add component documentation #19109
Conversation
alexandre-daubois
force-pushed
the
mention-panther
branch
from
d00625d to
d90c78a
Compare
|
I talked to @dunglas before and he agrees with the documentation move |
testing.rst
Outdated
|
|
||
| This is the purpose of `Panther`_, a library that provides a real browser | ||
| to run your tests. Here are a few things that make Panther special, compared | ||
| to other End to End testing tools: |
There was a problem hiding this comment.
| to other End to End testing tools: | |
| to other testing tools provided by Symfony: |
Because most, if not all, E2E testing tools have the capabilities described below.
alexandre-daubois
changed the title
alexandre-daubois
force-pushed
the
mention-panther
branch
3 times, most recently
from
32cdcf0 to
81e0c76
Compare
|
The PR is ready 🙂 I took every topic of the README and integrated it. I also updated with your suggested changes @dunglas, thank you 👍 |
components/panther.rst
Outdated
| Panther works out of the box with `GitHub Actions`_. | ||
| Here is a minimal ``.github/workflows/panther.yaml`` file to run Panther tests: | ||
|
|
||
| .. code-block:: yaml |
There was a problem hiding this comment.
@javiereguiluz WDYT ich we use a TAB directive here for the different CI systems?
|
I think we should target 6.4 branch, because symfony/panther:5.4 will never exist 🤔 |
alexandre-daubois
force-pushed
the
mention-panther
branch
2 times, most recently
from
83f40a6 to
0d85418
Compare
|
Rebased on 6.4 👍 |
|
@dunglas is this PR ready from your side? Are you planing to move panther to Symfony 6.4 or later? |
|
@OskarStark I think that in 6.4/7.0 we can no longer make any changes because their release is imminent (3 weeks). |
alexandre-daubois
force-pushed
the
mention-panther
branch
from
0d85418 to
5411430
Compare
carsonbot
changed the title
|
This is finally merged 🥳 Alex, thanks a lot for this great contribution and for your patience during the review process. |
|
Amazing! Thanks 🚀 |
|
We would need a PR on the panther repo to link to the Symfony docs |
Fix #12200
Had a quick chat with @OskarStark about adding complete documentation of Panther or not. As the README of the project is already full and well written, we thought it may deserve a mention in the Testing page rather than a full documentation page (which would only repeat the README after all)