[HttpClient] Add HttpOptions::addHeader method
#19291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean151
changed the title
Dean151
force-pushed
the
httpoptions-addoption
branch
from
dc43787 to
efef81b
Compare
xabbuh
reviewed
Dec 14, 2023
xabbuh
reviewed
Dec 26, 2023
http_client.rst
Outdated
| @@ -150,10 +150,17 @@ brings most of the available options with type-hinted getters and setters:: | |||
| $this->client = $client->withOptions( | |||
| (new HttpOptions()) | |||
| ->setBaseUri('https://...') | |||
| // Set headers replace *all* headers at once, and deletes the headers you do not provide | |||
There was a problem hiding this comment.
Suggested change
| // Set headers replace *all* headers at once, and deletes the headers you do not provide | |
| // setHeaders() replaces *all* headers at once, and deletes the headers you do not provide |
xabbuh
reviewed
Dec 26, 2023
http_client.rst
Outdated
| ->setHeaders(['header-name' => 'header-value']) | ||
| // Alternatively, add or replace only one header to an existing HttpOptions object. |
There was a problem hiding this comment.
Suggested change
| // Alternatively, add or replace only one header to an existing HttpOptions object. | |
| // add or replace a single header using addHeader() |
OskarStark
changed the title
HttpOptions::addHeader method
OskarStark
force-pushed
the
httpoptions-addoption
branch
from
9dd06ab to
436f69e
Compare
|
Thank you Thomas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19236
Not sure of the documentation format. Open to suggestion to improve it :)