[FrameworkBundle][Routing] Update the enabled_locales description
#19777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
reviewed
Apr 13, 2024
Comment on lines
-431
to
-433
| If some user makes requests with a locale not included in this option, the | ||
| application won't display any error because Symfony will display contents using | ||
| the fallback locale. |
There was a problem hiding this comment.
If there is no special locale parameter in request, this case is applied right ?
I think we should document it. I'm not sure what IS "fallback local", is it the default locale ?
There was a problem hiding this comment.
I don't understand your comment ... according to the code, if you use enabled_locales, the _locale will be set unconditionally:
94noni
reviewed
Apr 19, 2024
| added as a requirement of the :ref:`special _locale parameter <routing-locale-parameter>`. | ||
| For example, if you define this value as ``['ar', 'he', 'ja', 'zh']``, the | ||
| ``_locale`` routing parameter will have an ``ar|he|ja|zh`` requirement. If some | ||
| user makes requests with a locale not included in this option, they'll see an error. |
There was a problem hiding this comment.
Can we document what « error » ? 404 ?
There was a problem hiding this comment.
Yes, it's a 404 error. I added that while merging. Thanks!
94noni
approved these changes
Apr 19, 2024
carsonbot
changed the title
OskarStark
changed the title
enabled_locales description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on symfony/demo#1511 I found this feature, which works since Symfony 5.4. See:
https://github.com/symfony/symfony/blob/184597db05288c68c9eb11dff55239768268f646/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L1083-L1086