[Cache] Mention that user/password are not supported for Redis DSN #19957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jun 14, 2024
|
|
||
| .. note:: | ||
|
|
||
| A `Data Source Name (DSN)`_ for this adapter must use either one of the following formats. | ||
|
|
||
| .. code-block:: text | ||
|
|
||
| redis[s]://[pass@][ip|host|socket[:port]][/db-index] | ||
| redis[s]://[ip|host|socket[:port]][/db-index] |
There was a problem hiding this comment.
if I read the changes from symfony/symfony#45313 correctly, passing a password was possible before. Then reverting #17234 seems to be the solution to me.
There was a problem hiding this comment.
OK. But this revert must be applied only to 5.4, right? 6.4 and up should be kept unchanged.
There was a problem hiding this comment.
yes, that's how I see it as the support for this form was introduced in Symfony 6.1
There was a problem hiding this comment.
OK, I reverted everything that was added in #17234 ... and I'll readd it in 6.4 branch and up when merging this.
xabbuh
approved these changes
Jun 18, 2024
OskarStark
approved these changes
Jun 18, 2024
|
OK, this was merged ... and the changes reverted in 6.4 and up here: b7fe8d4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19955.