Skip to content

[Validator] Image Constraint - minPixels and maxPixels should be float #21486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

[Validator] Image Constraint - minPixels and maxPixels should be float #21486

merged 1 commit into from
Oct 13, 2025
+4 −4

Conversation

wkania
Copy link
Contributor

@wkania wkania commented Oct 9, 2025

Related to issue.

@wkania wkania requested a review from xabbuh as a code owner October 9, 2025 18:38
@carsonbot carsonbot added this to the 6.4 milestone Oct 9, 2025
xabbuh
xabbuh reviewed Oct 9, 2025
View reviewed changes
reference/constraints/Image.rst Outdated
~~~~~~~~~~~~~

**type**: ``integer``
**type**: ``float``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**type**: ``float``
**type**: ``integer`` | ``float``

see https://github.com/symfony/symfony/blob/0e59450e0cc04fffb7c5567c084b268dde784ad8/src/Symfony/Component/Validator/Constraints/Image.php#L109-L110

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from Video constraint. So maxRatio also needs a fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xabbuh fixed

Copy link
Contributor Author

@wkania wkania Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They all have the same set of types.

@wkania
Copy link
Contributor Author

wkania commented Oct 9, 2025

Error not related

@wkania wkania force-pushed the image_min_max_pixels_type branch from 6dcd826 to b9d1038 Compare October 9, 2025 18:49
@wkania wkania mentioned this pull request Oct 9, 2025
Merged
@javiereguiluz
Copy link
Member

Thanks @wkania.

@javiereguiluz javiereguiluz merged commit 6a2424c into symfony:6.4 Oct 13, 2025
2 of 3 checks passed
javiereguiluz added a commit that referenced this pull request Oct 13, 2025
@javiereguiluz
minor #21487 [Validator] Video Constraint - fix options order and typ…
dea322c 
…es (wkania)

This PR was merged into the 7.4 branch.

Discussion
----------

[Validator] Video Constraint - fix options order and types

Related to #21486

Fixed also alphabetic order of option names.

Commits
-------

8a6001d [Validator] Video Constraint - fix options order and types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees

No one assigned

Labels

Status: Reviewed Validator

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

4 participants

@wkania @javiereguiluz @xabbuh @carsonbot