Replace PHPDoc dataProvider with attribute syntax #21612
Conversation
carsonbot
changed the title
| /** | ||
| * @dataProvider urlProvider | ||
| */ | ||
| #[DataProvider('urlProvider')] |
There was a problem hiding this comment.
please make the data provider itself static, thanks
| /** | ||
| * @dataProvider urlProvider | ||
| */ | ||
| #[DataProvider('urlProvider')] |
There was a problem hiding this comment.
symfony-docs/validation/custom_constraint.rst
Line 584 in 3b6b704
Could also be updated ?
There was a problem hiding this comment.
@alamirault shall we create a DOCtor rule for using phpunit attributes and search and report the most common ones?
There was a problem hiding this comment.
We did this update while merging. Thanks!
There was a problem hiding this comment.
@alamirault shall we create a DOCtor rule for using phpunit attributes and search and report the most common ones?
Not yet, not enough occurrence
javiereguiluz
force-pushed
the
patch-1
branch
from
ce4883d to
6cc5b9c
Compare
|
I like this! Thanks Tom! We merged this in 7.3 and all the upper branches. |
5 participants
The attribute syntax is supported in PHPUnit v10, v11, and v12. It should be encouraged in Symfony 8.x, and maybe backport to Symfony 7.x?