Skip to content

add app.flashes() to the Twig reference #7900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2017
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented May 12, 2017

@xabbuh xabbuh added this to the 3.3 milestone May 12, 2017
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should remove the parenthesis? We don't explain anything about how app.flashes() arguments work, so we don't use any argument, so app.flashes() is the same as app.flashes in this case ... so we may remove the parenthesis to maintain consistency with the other items of this list.

@javiereguiluz
Copy link
Member

Thanks @xabbuh.

@javiereguiluz javiereguiluz merged commit b626c3e into symfony:master May 15, 2017
javiereguiluz added a commit that referenced this pull request May 15, 2017
…uiluz)

This PR was merged into the master branch.

Discussion
----------

add app.flashes() to the Twig reference

see #7808 (comment)

Commits
-------

b626c3e Minor typo
e066653 add app.flashes() to the Twig reference
@xabbuh xabbuh deleted the pr-7684 branch May 15, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants