Tweaks to spacing in diff #7938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
added a commit
that referenced
this pull request
May 22, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Tweaks to spacing in diff This was one of the first times I used the diff, so I made a few mistakes :). Each line with `-` or `+` needs to have a space after the `+` or `-`. This means that if a line is normally indented with 4 spaces, it will be indented *6* spaces (the `+` or `-` then 5 spaces). Commits ------- ff13686 Fixing bad indentation with diff
|
Merging this as it's very minor - just wanted to create a PR for a log, and to help other people using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the first times I used the diff, so I made a few mistakes :).
Each line with
-or+needs to have a space after the+or-. This means that if a line is normally indented with 4 spaces, it will be indented 6 spaces (the+or-then 5 spaces).