Skip to content

Tweaks to spacing in diff #7938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2017
Merged

Tweaks to spacing in diff #7938

merged 1 commit into from
May 22, 2017

Conversation

weaverryan
Copy link
Member

This was one of the first times I used the diff, so I made a few mistakes :).

Each line with - or + needs to have a space after the + or -. This means that if a line is normally indented with 4 spaces, it will be indented 6 spaces (the + or - then 5 spaces).

@weaverryan weaverryan merged commit ff13686 into symfony:3.3 May 22, 2017
weaverryan added a commit that referenced this pull request May 22, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

Tweaks to spacing in diff

This was one of the first times I used the diff, so I made a few mistakes :).

Each line with `-` or `+` needs to have a space after the `+` or `-`. This means that if a line is normally indented with 4 spaces, it will be indented *6* spaces (the `+` or `-` then 5 spaces).

Commits
-------

ff13686 Fixing bad indentation with diff
@weaverryan
Copy link
Member Author

Merging this as it's very minor - just wanted to create a PR for a log, and to help other people using the diff type in the future. I know it doesn't have syntax highlighting, but I LOVE the diff :) :) :)

@weaverryan weaverryan deleted the diff-tweaks branch May 22, 2017 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants