Skip to content
This repository was archived by the owner on Nov 27, 2020. It is now read-only.

Add VarDumper's dump.php to autoload-dev #1025

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

nicolas-grekas
Copy link
Member

Pragmatical fix for symfony/symfony#20201

@Pierstoval
Copy link
Contributor

I'm not sure I agree with this. Having both symfony/symfony and symfony/var-dumper should be something supported, as the first one contains the second one...

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Nov 23, 2016

@Pierstoval having symfony/symfony and symfony/var-dumper as standalone vendor is not possible because symfony/symfony replaces symfony/var-dumper in composer.json. Note also that this PR isn't making this new so I don't get why you expressed a 👎 here.

@Pierstoval
Copy link
Contributor

I just don't get the real point of this, it seems to express an issue for users wanting to use dump before enabling DebugBundle, so in this case, it brings the feature "out of symfony", which can also be done by using auto_prepend_file's php.ini config option, or by enabling the dumper manually in the Symfony's autoloader.

I think having this in symfony standard adds more complexity to the composer.json file for too specific cases, that's why I put a 👎 , but still it's just an opinion 😉

@xabbuh
Copy link
Member

xabbuh commented Nov 25, 2016

👍

@javiereguiluz
Copy link
Member

javiereguiluz commented Jan 17, 2017

@Pierstoval the Scenario #1 explained in symfony/symfony#20201 could be enough reason to enable this: it will allow to use dump() anywhere in your app. Besides, the "performance impact" is minimal because it's just one file.

I'm 👍

@lyrixx
Copy link
Member

lyrixx commented Jan 17, 2017

I don't really like this approach.
I prefer to install the var dumper globally. then I can really use it anywhere.
see: https://github.com/lyrixx/dotfiles/blob/master/php/90-my.ini#L10

@ghost
Copy link

ghost commented Mar 10, 2017

some people still use symfony on shared hosting, so this would be nice for them. Perhaps flex will solve it somehow? perhaps some generator for helpful bits on shared hosting?

@nicolas-grekas
Copy link
Member Author

Can't we merge this one ? I thought it was already.
There no down side. Use a global install if you prefer @lyrixx, but asking everyone to know how to do it is asking for too much. The DX should be great by default without requiring people to learn yet another concept/option before they have the full setup.

@lyrixx
Copy link
Member

lyrixx commented Mar 10, 2017

👍

Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fabpot
Copy link
Member

fabpot commented Mar 10, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 7fe1143 into symfony:2.7 Mar 10, 2017
fabpot added a commit that referenced this pull request Mar 10, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Add VarDumper's dump.php to autoload-dev

Pragmatical fix for symfony/symfony#20201

Commits
-------

7fe1143 Add VarDumper's dump.php to autoload-dev
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants