This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Use HTTPS for links to the docs #1083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Jun 1, 2017
| @@ -19,7 +19,7 @@ | |||
| <div id="next"> | |||
| <h2>What's next?</h2> | |||
| <p> | |||
| <svg id="icon-book" version="1.1" xmlns="http://www.w3.org/2000/svg" x="0px" y="0px" viewBox="-12.5 9 64 64" enable-background="new -12.5 9 64 64" xml:space="preserve"> | |||
| <svg id="icon-book" version="1.1" xmlns="https://www.w3.org/2000/svg" x="0px" y="0px" viewBox="-12.5 9 64 64" enable-background="new -12.5 9 64 64" xml:space="preserve"> | |||
There was a problem hiding this comment.
that's wrong. The official XML namespace for SVG does not have https in it (the website uses HTTPS, but this does not impact the XML namespace)
There was a problem hiding this comment.
Ah, I followed the link and was redirected to the https, that's why I decided to change it.
Thanks, I'll revert it!
phpunit.xml.dist
Outdated
| @@ -1,8 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
|
|||
| <!-- https://phpunit.de/manual/current/en/appendixes.configuration.html --> | |||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.8/phpunit.xsd" | |||
| <phpunit xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance" | |||
|
Thank you @bocharsky-bw. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was done in Symfony Demo symfony/demo#550