-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Runtime] Make project_dir configurable #59974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Runtime] Make project_dir configurable #59974
Conversation
ffbd495 to
09e301d
Compare
nicolas-grekas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be tested?
Note that this should target 7.3 as it's an improvement, not a butfix
i'm not entirely sure as the plugin uses a lot of built in functions with regards to directory / file locations and a static method to retrieve a composer config.... would you guys even be open to have a dev depdency like vfsStream?
check |
09e301d to
949db49
Compare
- add project_dir to configurable options in composer extra.runtime
949db49 to
1d085aa
Compare
|
Thank you @wickedOne. |
this would allow a
composer.jsonfile at/alternative/location/composer.jsonbe configured withwhile using
generate a
autoload_runtime.phpwith the followingproject_diri did not meddle with the autoload template discovery as that's currently already configurable and would introduce a bc break. also it makes sense in a way that every config value is relative to the composer.json file itself