[LazyImage] Fix cache implementation #1761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbond
approved these changes
Apr 20, 2024
carsonbot
added
Status: Reviewed
|
Good catch, thanks Hugo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1755 (comment),
BlurHash#createDataUriThumbnailcould not use the cache because it call$this->encode(), which refers toBlurHash#encodeand notCachedBlurHash#encode.So I went back with my previous implementation by injecting (or not) a
CacheAdapterimplementation toBlurHash, and use it if necessary.I've cheated a bit to adapt test, because I really want to ensure
$cacheis used or not.