[Turbo] Add Vary header for stream responses in docs #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Jan 11, 2022
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| Tickets | n/a |
| License | MIT |
| // The same URL will return a response with a different Content-Type HTTP header | ||
| // depending on the Accept request header. | ||
| // To prevent cache pollution issues, we must set the Vary response header. | ||
| #[Cache(vary: ['Accept'])] |
There was a problem hiding this comment.
but this is not needed actually, since the call to getPreferredFormat is nested in $form->isSubmitted() && $form->isValid(), which means POST, which means no-cache.
There was a problem hiding this comment.
More or less but:
- Turbo Streams can be used with GET requests too, this adds an example of how to handle content negotiation properly
- It's a best practice anyway to set Vary regardless of the verb
- Even if it's not commonly implemented by cache servers, responses to POST requests can be cached (by the spec) and reused for subsequent GET requests for the same resource
There was a problem hiding this comment.
Yes, but this example is about a form. The example you added in #217 has return $response->setVary('Accept');, which is enough a hint to me.
Here, yes, POST can be cached, but ONLY if Cache-Control is sent. I think that if one does that (set the cc header), then it's their job to also add the Vary, and we don't have to tell everybody to add it.
chalasr
added a commit
that referenced
this pull request
Jan 12, 2022
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Turbo] Simplify stream negotiation | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT This patch replaces the ad-hoc content negotiation system for Turbo Streams used by the bundle. HttpFoundation's native content negotiation features are now used instead. This greatly simplifies the code, which is security-sensitive, and improves DX (content negotiation is now consistent with how it is handled in the rest of the framework). Replaces #214. Needs #215 and symfony/symfony#44980. Commits ------- b6de1e3 [Turbo] Simplify stream negotiation
symfony-splitter
pushed a commit
to symfony/ux-turbo
that referenced
this pull request
Jan 12, 2022
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Turbo] Simplify stream negotiation | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT This patch replaces the ad-hoc content negotiation system for Turbo Streams used by the bundle. HttpFoundation's native content negotiation features are now used instead. This greatly simplifies the code, which is security-sensitive, and improves DX (content negotiation is now consistent with how it is handled in the rest of the framework). Replaces symfony/ux#214. Needs symfony/ux#215 and symfony/symfony#44980. Commits ------- b6de1e3 [Turbo] Simplify stream negotiation
marcuswebapp
added a commit
to marcuswebapp/ux
that referenced
this pull request
Aug 1, 2023
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Turbo] Simplify stream negotiation | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT This patch replaces the ad-hoc content negotiation system for Turbo Streams used by the bundle. HttpFoundation's native content negotiation features are now used instead. This greatly simplifies the code, which is security-sensitive, and improves DX (content negotiation is now consistent with how it is handled in the rest of the framework). Replaces symfony/ux#214. Needs symfony/ux#215 and symfony/symfony#44980. Commits ------- b6de1e3 [Turbo] Simplify stream negotiation
symfony-splitter
pushed a commit
to symfony/ux-turbo
that referenced
this pull request
Sep 22, 2023
This PR was squashed before being merged into the 2.x branch. Discussion ---------- [Turbo] Simplify stream negotiation | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes <!-- please update src/**/CHANGELOG.md files --> | Tickets | n/a | License | MIT This patch replaces the ad-hoc content negotiation system for Turbo Streams used by the bundle. HttpFoundation's native content negotiation features are now used instead. This greatly simplifies the code, which is security-sensitive, and improves DX (content negotiation is now consistent with how it is handled in the rest of the framework). Replaces symfony/ux#214. Needs symfony/ux#215 and symfony/symfony#44980. Commits ------- b6de1e3 [Turbo] Simplify stream negotiation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.