[CI] Cache Composer dependencies #2882
Conversation
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} | ||
| cancel-in-progress: true | ||
|
|
There was a problem hiding this comment.
I've found functional tests were not canceled when pushing a new commit when they are already running.
Kocal
force-pushed
the
ci-cache-dependencies
branch
6 times, most recently
from
d1aa3a2 to
ec5420a
Compare
Kocal
force-pushed
the
ci-cache-dependencies
branch
from
ec5420a to
04b575a
Compare
|
Doesn't |
|
I started to remove ramsey/composer-install in #2780 because I thought it silenced errors when composer failed to install (or update IIRC) dependencies, but I was wrong, the raw Maybe the most clever thing to do here is to re-add ramsey/composer-install everywhere. WDYT? |
|
I always use to avoid cache complexity |
|
We can add a custom cache key if we need it: https://github.com/ramsey/composer-install?tab=readme-ov-file#custom-cache-key |
|
I'm closing this PR, I will re-open a new one |
…e (Kocal) This PR was squashed before being merged into the 2.x branch. Discussion ---------- [CI] (Re-)use ramsey/composer-install action when possible | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Replace #2882 Commits ------- 71f9723 [CI] (Re-)use ramsey/composer-install action when possible
Following #2780 (comment).
Also, sometimes the CI fails because Composer is not able to download files (e.g.: https://github.com/symfony/ux/actions/runs/15955763737/job/45001822817?pr=2880):