Skip to content

[Dropzone] Added support for upload and preview multiple files - #3162

Closed
karheda wants to merge 17 commits into
symfony:2.xfrom
karheda:2.x
Closed

[Dropzone] Added support for upload and preview multiple files#3162
karheda wants to merge 17 commits into
symfony:2.xfrom
karheda:2.x

Conversation

@karheda

@karheda karheda commented Nov 10, 2025

Copy link
Copy Markdown

…coverage, and adjust styles.

Q A
Bug fix? no
New feature? yes
Deprecations? no
Documentation? no
Issues #2567
License MIT

Added support for uploading multiple files in UX Dropzone and displaying them in the preview.

@carsonbot carsonbot added Dropzone Feature New Feature Status: Needs Review Needs to be reviewed labels Nov 10, 2025
@github-actions

github-actions Bot commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

📊 Packages dist files size difference

Thanks for the PR! Here is the difference in size of the packages dist files between the base branch and the PR.
Please review the changes and make sure they are expected.

FileBefore (Size / Gzip)After (Size / Gzip)
Dropzone
controller.d.ts 723 B / 337 B 958 B+33% 📈 / 425 B+26% 📈
controller.js 2.92 kB / 819 B 4.43 kB+52% 📈 / 1.34 kB+67% 📈
style.min.css 944 B / 468 B 959 B+2% 📈 / 472 B+1% 📈

Carlos Hernández added 5 commits November 10, 2025 11:39
- Format array declarations for better readability in `controller.ts`.
- Correct typos in `CHANGELOG.md`.
- Adjust imports for consistency in `vitest.config.mjs`.
- Refactor `vitest.setup.js` for improved code structure.
…d UI logic for preview visibility and structure.
@davidnectarestudio

Copy link
Copy Markdown

@Kocal can you take a look to the failing check, please? It would be appreciate it if you can write some hint about how to solve it, thanks.

@Kocal

Kocal commented Nov 20, 2025

Copy link
Copy Markdown
Member

Hi, you can rebase your PR on latest 2.x, it was fixed in #3159.

@karheda
karheda requested a review from Kocal as a code owner November 25, 2025 09:51
@karheda

karheda commented Nov 25, 2025

Copy link
Copy Markdown
Author

Hi @Kocal, I just made the rebase, and new failing checks arised.

@Kocal

Kocal commented Dec 1, 2025

Copy link
Copy Markdown
Member

Hi,

Can you move your work in a dedicated source branch (not 2.x) and rebase it? There are a lot of commits that should not be there.

Thanks!

@Kocal Kocal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some documentation must be added, can you add a section explaining how to enable multiple-files upload?

Thanks!

"name": "@symfony/ux-dropzone",
"description": "File input dropzones for Symfony Forms",
"license": "MIT",
"version": "2.31.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To revert, version from package.json are automatically updated when creating a new tag

Comment thread src/Dropzone/CHANGELOG.md
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.31

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## 2.31
## 2.32

Comment thread src/Dropzone/CHANGELOG.md

## 2.31

- Support for multiple files drag and drop and peviews

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Support for multiple files drag and drop and peviews
- Add support for multiple files upload

@carsonbot carsonbot added Status: Needs Work Additional work is needed and removed Status: Needs Review Needs to be reviewed labels Dec 1, 2025
@karheda karheda closed this Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dropzone Feature New Feature Status: Needs Work Additional work is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants